Improve latest download #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user can now specify custom file extensions to serve as latest release.
Now the user can get the latest version of a custom channel and custom flavor
Now the API is only accessible through authentication Authentication is done through headers/cookies
ArekSredzki
approved these changes
May 12, 2022
|
Sorry @ArekSredzki I was not aware that this PR was merging my master into your master. After creating this PR, I have pushed 8d2099f which breaks the latest download page (on purpose). This is not something you want to have in your master. I propose to revert this PR and that you cherry pick ever commit except 8d2099f |
ArekSredzki
added a commit
that referenced
this pull request
May 12, 2022
This reverts commit 2aacccf.
ArekSredzki
added a commit
that referenced
this pull request
May 12, 2022
|
Thanks for the heads up @JJ-8. My bad for not having tested it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed:
PlatformService.detectso you don't have to specify a perfect match anymorereleases/directory is added to.gitignoreThe documentation is updated accordingly.