Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return correct status codes and messages when a user changes their password #540

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

DevDonut
Copy link
Contributor

@DevDonut DevDonut commented Jan 2, 2021

No description provided.

@DevDonut DevDonut requested a review from skamoen January 2, 2021 12:25
@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #540 (398468d) into master (9cd7086) will increase coverage by 0.79%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #540      +/-   ##
============================================
+ Coverage     80.05%   80.85%   +0.79%     
- Complexity      601      605       +4     
============================================
  Files           112      112              
  Lines          1800     1807       +7     
  Branches        112      114       +2     
============================================
+ Hits           1441     1461      +20     
+ Misses          323      310      -13     
  Partials         36       36              
Impacted Files Coverage Δ
...lan/security/authentication/PasswordChangeDTO.java 100.00% <ø> (ø)
...an/users/controller/CurrentUserRestController.java 78.26% <77.77%> (-2.99%) ⬇️
...reafiftylan/products/service/OrderServiceImpl.java 96.58% <0.00%> (+2.56%) ⬆️
...sv/areafiftylan/users/service/UserServiceImpl.java 60.37% <0.00%> (+2.83%) ⬆️
...ylan/products/model/TicketInformationResponse.java 75.00% <0.00%> (+75.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd7086...398468d. Read the comment docs.

@ArdyZ
Copy link
Member

ArdyZ commented Dec 22, 2021

@dsluijk and @DevDonut what should be done to fix this pull request and merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants