-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement/aboutpage #30
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good, but have a look at the requested changes.
Also when having the page open I can scroll to the right ending in a weird counter, what is this for and shouldn't it wrap around starting with the new image or not even be scrollable at all?
@@ -0,0 +1,79 @@ | |||
<template> | |||
<div> | |||
<h2 class="image_scroller_title">{{ title }}</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title is sometimes not that well visible. Maybe add a background with 0.5 ocupacity. See the login page for an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think the best option is to have the second image (Box around the title), however put it in the bottom right corner. @MaritRadder what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…nto implement/aboutpage
base frontend for about us page
NOTE: image scroller speed still hardcoded