Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement/aboutpage #30

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Implement/aboutpage #30

wants to merge 18 commits into from

Conversation

ajaggoe
Copy link

@ajaggoe ajaggoe commented Oct 20, 2022

base frontend for about us page

NOTE: image scroller speed still hardcoded

Copy link
Member

@ArdyZ ArdyZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good, but have a look at the requested changes.

Also when having the page open I can scroll to the right ending in a weird counter, what is this for and shouldn't it wrap around starting with the new image or not even be scrollable at all?

@@ -0,0 +1,79 @@
<template>
<div>
<h2 class="image_scroller_title">{{ title }}</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is sometimes not that well visible. Maybe add a background with 0.5 ocupacity. See the login page for an example.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is true. I have added two implementations of the slightly opaque background, both of which in the theme color. One more in the style of the login page and the other as a small box around the title. I am in favor of the former, but this is a design change we should probably decide on together
image
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think the best option is to have the second image (Box around the title), however put it in the bottom right corner. @MaritRadder what do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something like this:
image
Is best. I updated the design accordingly. I did it quite fast so padding and stuff is not very accurate.

components/ImageScroll.vue Show resolved Hide resolved
components/TheHeader.vue Outdated Show resolved Hide resolved
components/TheHeader.vue Outdated Show resolved Hide resolved
pages/aboutus.vue Outdated Show resolved Hide resolved
components/ImageScroll.vue Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants