Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: external link hover styling on select delegate page #808

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

ItsANameToo
Copy link
Contributor

Summary

https://app.clickup.com/t/86dv4fczj

The truncate class causes it to lose the border that gets applied on hover on certain systems. As a result, an underline was forced to get the line back but this clashes with systems where the border is not lost and results in a double underline

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Nov 11, 2024 2:25pm

@ItsANameToo ItsANameToo changed the title chore: bump version 1.18.0 fix: external link hover styling on select delegate page Nov 11, 2024
@github-actions github-actions bot added the chore label Nov 11, 2024
@ItsANameToo ItsANameToo merged commit ce21938 into rc-1.18.0 Nov 11, 2024
20 checks passed
@ItsANameToo ItsANameToo deleted the fix/external-icon-delegate-select branch November 11, 2024 14:35
@ItsANameToo ItsANameToo added this to the 1.18.0 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants