-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: handle total and sent to self for unconfirmed transactions #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shahin-hq
changed the title
refactor: handle sent to self with musig return transactions
refactor: handle total and sent to self for unconfirmed transactions
Nov 5, 2024
…factor/tx-amount-hint
…-transaction-direction # Conflicts: # src/domains/transaction/components/TransactionTable/TransactionRow/TransactionAmount.blocks.tsx # src/domains/transaction/components/TransactionTable/TransactionRow/TransactionRowAddressing.tsx
…tion' into refactor/musig-transaction-direction
…tion' into refactor/musig-transaction-direction
…tion' into refactor/musig-transaction-direction # Conflicts: # src/domains/transaction/components/TransactionTable/TransactionRow/TransactionBlocks.test.tsx
shahin-hq
requested review from
ItsANameToo,
samharperpittam,
goga-m,
boldninja and
alexbarnsley
as code owners
November 6, 2024 13:48
…ection # Conflicts: # src/domains/transaction/components/TransactionTable/TransactionRow/TransactionAmount.blocks.tsx # src/domains/transaction/components/TransactionTable/TransactionRow/TransactionBlocks.test.tsx # src/domains/transaction/components/TransactionTable/TransactionRow/TransactionRowAddressing.tsx
ItsANameToo
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #795
Closes: https://app.clickup.com/t/86dv3mv9f
A musig wallet:
DG251q3GRUzTsS6FGrx5tZrEhG8C4iVWVS
A participant:
DKM6QNS5bLggQmUbtpXiARCgjvwhXGNq4Z
Another participant for testing:
DErsBi7QDiqxj6jh5C5VgK3qaksQbkG6F9
Related PSDK: ArdentHQ/platform-sdk#108
Checklist