Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: handle total and sent to self for unconfirmed transactions #797

Merged
merged 30 commits into from
Nov 6, 2024

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Nov 5, 2024

Summary

Depends on #795

Closes: https://app.clickup.com/t/86dv3mv9f

A musig wallet: DG251q3GRUzTsS6FGrx5tZrEhG8C4iVWVS
image

A participant: DKM6QNS5bLggQmUbtpXiARCgjvwhXGNq4Z
image

Another participant for testing: DErsBi7QDiqxj6jh5C5VgK3qaksQbkG6F9

Related PSDK: ArdentHQ/platform-sdk#108

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Nov 6, 2024 2:38pm

@shahin-hq shahin-hq changed the title refactor: handle sent to self with musig return transactions refactor: handle total and sent to self for unconfirmed transactions Nov 5, 2024
shahin-hq and others added 5 commits November 6, 2024 15:47
…-transaction-direction

# Conflicts:
#	src/domains/transaction/components/TransactionTable/TransactionRow/TransactionAmount.blocks.tsx
#	src/domains/transaction/components/TransactionTable/TransactionRow/TransactionRowAddressing.tsx
…tion' into refactor/musig-transaction-direction

# Conflicts:
#	src/domains/transaction/components/TransactionTable/TransactionRow/TransactionBlocks.test.tsx
@shahin-hq shahin-hq marked this pull request as ready for review November 6, 2024 13:48
@shahin-hq shahin-hq added this to the 1.18.0 milestone Nov 6, 2024
Base automatically changed from refactor/tx-amount-hint to develop November 6, 2024 14:31
…ection

# Conflicts:
#	src/domains/transaction/components/TransactionTable/TransactionRow/TransactionAmount.blocks.tsx
#	src/domains/transaction/components/TransactionTable/TransactionRow/TransactionBlocks.test.tsx
#	src/domains/transaction/components/TransactionTable/TransactionRow/TransactionRowAddressing.tsx
@ItsANameToo ItsANameToo merged commit c7c59f4 into develop Nov 6, 2024
20 checks passed
@ItsANameToo ItsANameToo deleted the refactor/musig-transaction-direction branch November 6, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants