Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: button hover styles #793

Merged
merged 137 commits into from
Nov 7, 2024
Merged

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Nov 4, 2024

[general] various hover state updates

Summary

  • The primary and secondary button styles have been refactored to match the design.
  • New navy and green variants to help manage style changes for certain color variations depending on the selected palette.
  • StarFilled svg has been refactored to allow managing different colors for the fill and the stroke.
  • Home page profile button hover styles have been refactored:
image
  • Create profile page button hover styles have been updated:
image
  • Portfolio page table hover styles (star icon, buttons and row hover):
image
  • Completed transactions hover styles for buttons:
image
  • Send transfer page button hover styles:
image
  • Exchange table hover styles (row and buttons):
image
  • Votes page hover styles (table rows, buttons from both the header and tables, icons):
image
  • Select delegate table hover styles:
image
  • Transaction details modal hover styles for buttons:
image
  • Wallet page:

This is one of the most complex pages to test: the header, the tables, the rows and the buttons have been updated.

image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patricio0312rev - can we make sure all pages with icons in the header are green when using the green theme?

This includes Create/Import/Verify/Ledger and any other page that contains an icon in the header.

image

@samharperpittam samharperpittam marked this pull request as draft November 6, 2024 12:58
@samharperpittam samharperpittam marked this pull request as ready for review November 6, 2024 13:01
@ItsANameToo ItsANameToo merged commit bb29e88 into develop Nov 7, 2024
21 checks passed
@ItsANameToo ItsANameToo deleted the refactor/button-hover-styles branch November 7, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants