Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add alias for recipient field #783

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Oct 28, 2024

Summary

Closes: https://app.clickup.com/t/86dv0y0uy

When an alias exists:
image

When doesn't exist:
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Oct 30, 2024 11:50am

@shahin-hq shahin-hq marked this pull request as ready for review October 28, 2024 12:58
Copy link
Contributor

@goga-m goga-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works good 👍 @shahin-hq

Not sure if we want to align the address font-weights with the sender too, as sender is semibold 🤔

cc @samharperpittam

@ItsANameToo ItsANameToo merged commit 4e2f8a6 into develop Oct 30, 2024
20 checks passed
@ItsANameToo ItsANameToo deleted the fix/add-address-alias branch October 30, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants