Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: button styles #780

Merged
merged 34 commits into from
Nov 4, 2024
Merged

refactor: button styles #780

merged 34 commits into from
Nov 4, 2024

Conversation

patricio0312rev
Copy link
Contributor

[general] refactor button styles

Summary

  • Button props for roundedClassName and sizeClassName have been removed.
  • Implementations of these props have been refactored to simply use className.
  • Snapshots have been updated.

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Nov 4, 2024 2:35am

@patricio0312rev patricio0312rev added this to the 1.18.0 milestone Oct 28, 2024
@shahin-hq
Copy link
Contributor

I'd be careful with components with extra added classes, it might break something quitely:

image

@samharperpittam samharperpittam marked this pull request as draft October 31, 2024 09:57
@samharperpittam
Copy link

Moved to draft due to the issue @shahin-hq mentioned above.

@patricio0312rev patricio0312rev marked this pull request as ready for review November 4, 2024 02:01
@patricio0312rev
Copy link
Contributor Author

@samharperpittam should be ready now 🌟

@ItsANameToo ItsANameToo merged commit 33dee2b into develop Nov 4, 2024
20 checks passed
@ItsANameToo ItsANameToo deleted the refactor/button-styles branch November 4, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahin-hq shahin-hq shahin-hq left review comments

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@patricio0312rev @shahin-hq @samharperpittam @ItsANameToo