Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modal padding #772

Merged
merged 4 commits into from
Oct 24, 2024
Merged

fix: modal padding #772

merged 4 commits into from
Oct 24, 2024

Conversation

patricio0312rev
Copy link
Contributor

[transaction details] modal should be full screen on mobile

Summary

  • Visual padding issue with modals has been fixed.
  • Custom scrollbar class has been added to the modals.
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Oct 24, 2024 1:07pm

@ItsANameToo ItsANameToo added this to the 1.18.0 milestone Oct 24, 2024
@patricio0312rev patricio0312rev merged commit 1a82caa into develop Oct 24, 2024
20 checks passed
@patricio0312rev patricio0312rev deleted the fix/modal-padding branch October 24, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahin-hq shahin-hq shahin-hq approved these changes

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@patricio0312rev @samharperpittam @shahin-hq @ItsANameToo