Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: green background for selected rows #763

Merged
merged 23 commits into from
Oct 28, 2024

Conversation

patricio0312rev
Copy link
Contributor

[sender/recipient modals] add green background to "selected" address

Summary

  • TableCell component and styles have been refactored to support isSelected props.
  • Both the "Select sender" and "Select recipient" tables have been refactored.

## Screenshots

image image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Oct 26, 2024 2:45am

Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget dark mode :D
image

Can use the same styling that we use on the Votes page when a delegate is selected.

@samharperpittam samharperpittam marked this pull request as draft October 24, 2024 10:40
@patricio0312rev
Copy link
Contributor Author

@samharperpittam should be fixed now 🌟
image

@shahin-hq
Copy link
Contributor

shahin-hq commented Oct 24, 2024

There is something off with paddings of the first and last items:

Delegates page:

image

Recipient search:

image

@ItsANameToo ItsANameToo marked this pull request as draft October 25, 2024 07:40
@patricio0312rev
Copy link
Contributor Author

@shahin-hq thanks for the review! 🌟
Actually, I think that the delegate selection page is missing that low padding. As you can see in the designs, the last row always has an extra bottom padding.

image

@patricio0312rev patricio0312rev marked this pull request as ready for review October 26, 2024 02:50
@ItsANameToo ItsANameToo merged commit 639c75b into develop Oct 28, 2024
38 of 39 checks passed
@ItsANameToo ItsANameToo deleted the refactor/green-background-for-selected-row branch October 28, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants