refactor: second signature transaction step adjustments #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…step' into refactor/adjust-musig-tx-review-step
…step' into refactor/adjust-musig-tx-review-step # Conflicts: # src/domains/transaction/components/MultiSignatureRegistrationForm/ReviewStep.tsx
…step' into refactor/adjust-musig-tx-review-step
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shahin-hq
requested review from
ItsANameToo,
samharperpittam,
goga-m,
boldninja and
alexbarnsley
as code owners
shahin-hq
commented
Sep 27, 2024
| useEffect(() => { | ||
| register("verification", { required: true }); | ||
| }, [register]); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
This is here to make testing easier, I'll remove this once it is approved
fyi @samharperpittam, open your dev console to see mnemonic in the verification step
samharperpittam
approved these changes
Sep 27, 2024
ItsANameToo
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements all steps of the second signature transaction except success step.
Closes:
Checklist