Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: musig transaction review step adjustments #671

Merged
merged 28 commits into from
Sep 27, 2024

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Sep 25, 2024

Summary

Closes: https://app.clickup.com/t/86duqu2pt

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Sep 26, 2024 1:10pm

…step' into refactor/adjust-musig-tx-review-step

# Conflicts:
#	src/domains/transaction/components/MultiSignatureRegistrationForm/ReviewStep.tsx
@goga-m goga-m merged commit 0f642b4 into develop Sep 27, 2024
55 of 57 checks passed
@goga-m goga-m deleted the refactor/adjust-musig-tx-review-step branch September 27, 2024 10:24
@ItsANameToo ItsANameToo added this to the 1.17.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants