Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: show all wallets page #665

Merged
merged 17 commits into from
Sep 26, 2024
Merged

refactor: show all wallets page #665

merged 17 commits into from
Sep 26, 2024

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Sep 23, 2024 •
edited
Loading

[wallet] Show All Wallets page UI is outdated

Summary

  • "Show all wallets" page has been refactored and now displays the UI according to the new designs.
  • Snapshots have been updated to match these changes.

Screenshots

  • 320px:
image
  • 640px:
image
  • 768px:
image
  • 1024px:
image
  • 1280px:
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Sep 25, 2024 10:42am

@patricio0312rev patricio0312rev marked this pull request as draft September 23, 2024 12:26
@patricio0312rev patricio0312rev added this to the 1.17.0 milestone Sep 23, 2024
@patricio0312rev patricio0312rev marked this pull request as ready for review September 25, 2024 03:59
samharperpittam
samharperpittam requested changes Sep 25, 2024
View reviewed changes
Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using pagination and viewing the end of the list, after the last entry in the table should contain a bottom border.

Design
image

@samharperpittam samharperpittam marked this pull request as draft September 25, 2024 08:59
@patricio0312rev patricio0312rev marked this pull request as ready for review September 25, 2024 09:47
@goga-m goga-m merged commit 267f95e into develop Sep 26, 2024
29 checks passed
@goga-m goga-m deleted the refactor/show-all-wallets-page branch September 26, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goga-m goga-m goga-m approved these changes

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patricio0312rev @goga-m @samharperpittam