Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Adjust multisignature transaction step 1 page #662

Merged
merged 24 commits into from
Sep 24, 2024
Merged

refactor: Adjust multisignature transaction step 1 page #662

merged 24 commits into from
Sep 24, 2024

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Sep 20, 2024 •
edited
Loading

Summary

Closes: https://app.clickup.com/t/86duqdmpj

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Sep 24, 2024 0:18am

@shahin-hq shahin-hq marked this pull request as ready for review September 23, 2024 18:00
@shahin-hq shahin-hq merged commit 7e16439 into develop Sep 24, 2024
29 checks passed
@shahin-hq shahin-hq deleted the refactor/adjust-musig-step-1 branch September 24, 2024 12:36
@ItsANameToo ItsANameToo added this to the 1.17.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goga-m goga-m goga-m approved these changes

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahin-hq @goga-m @samharperpittam @ItsANameToo