Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: portfolio table design adjustments #657

Merged
merged 45 commits into from
Sep 20, 2024
Merged

refactor: portfolio table design adjustments #657

merged 45 commits into from
Sep 20, 2024

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Sep 18, 2024 •
edited
Loading

Summary

Closes: https://app.clickup.com/t/86dunuzb8

Note: this PR handles more than the given task, it adjusts portfolio table to match the new design

Design: https://www.figma.com/design/o6b1tEMOdUtHv7ijVs6pMX/ARKVault?node-id=13506-21191&node-type=frame&m=dev

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Sep 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Sep 20, 2024 10:41am

@shahin-hq shahin-hq marked this pull request as ready for review September 19, 2024 18:55
@goga-m
Copy link
Contributor

goga-m commented Sep 20, 2024

@shahin-hq @samharperpittam noticing that in the wallet table the dropdown is hidden when it exceeds the table container, while in develop it seems to be working 🤔

This PR:
2024-09-20-113142_360x219_scrot

Develop:
2024-09-20-113125_564x398_scrot

goga-m
goga-m requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@goga-m goga-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another minor thing that I spotted on the loading state on mobile.

The skeleton is a bit too closer with the divider.

Designs show:

2024-09-20-113841_820x384_scrot

But the skeleton seems a bit closer than that:
2024-09-20-113535_312x175_scrot

@shahin-hq
Copy link
Contributor Author

@goga-m fixed

image

image

@goga-m goga-m mentioned this pull request Sep 20, 2024
Merged
6 tasks
@shahin-hq shahin-hq requested a review from goga-m September 20, 2024 10:54
goga-m
goga-m approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@goga-m goga-m left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving @samharperpittam @shahin-hq I have fixed the dropdown issue in #661, so we can merge it after this

@goga-m goga-m merged commit d1abeb2 into develop Sep 20, 2024
29 checks passed
@goga-m goga-m deleted the refactor/adjust-portflio-table branch September 20, 2024 12:24
@ItsANameToo ItsANameToo added this to the 1.17.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samharperpittam samharperpittam samharperpittam approved these changes

@goga-m goga-m goga-m approved these changes

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahin-hq @goga-m @samharperpittam @ItsANameToo