Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove borders from amount label #656

Merged
merged 13 commits into from
Sep 19, 2024
Merged

refactor: remove borders from amount label #656

merged 13 commits into from
Sep 19, 2024

Conversation

patricio0312rev
Copy link
Contributor

[general] remove border from amounts

Summary

  • Borders from AmountLabel have been entirely removed.
  • These component class names have also been refactored.
  • Snapshots updated for these changes.
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Sep 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Sep 19, 2024 1:37pm

@patricio0312rev patricio0312rev marked this pull request as ready for review September 18, 2024 20:47
@goga-m
Copy link
Contributor

goga-m commented Sep 19, 2024

@patricio0312rev some snap conflicts after recent merges

@patricio0312rev patricio0312rev merged commit 9727e64 into develop Sep 19, 2024
29 checks passed
@patricio0312rev patricio0312rev deleted the refactor/remove-borders-from-amount-label branch September 19, 2024 13:55
@ItsANameToo ItsANameToo added this to the 1.17.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samharperpittam samharperpittam samharperpittam approved these changes

@goga-m goga-m goga-m approved these changes

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patricio0312rev @goga-m @samharperpittam @ItsANameToo