Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: adjust delegate registration review step #647

Merged
merged 81 commits into from
Sep 16, 2024
Merged

refactor: adjust delegate registration review step #647

merged 81 commits into from
Sep 16, 2024

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Sep 12, 2024 •
edited
Loading

Summary

Closes: https://app.clickup.com/t/86dumjmef

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

shahin-hq and others added 30 commits September 10, 2024 19:18
@shahin-hq
refactor: remove expanded tables
a6c4c83
@shahin-hq
refactor: remove expanded tables
a61e082
@shahin-hq
refactor: remove expanded tables
7e93ab1
@shahin-hq
refactor: remove expanded tables
f290e67
@shahin-hq
refactor: remove expanded tables
427cd1b
@shahin-hq @github-actions
style: resolve style guide violations
00a1a06
@shahin-hq
refactor: remove expanded tables
fd6da32
@shahin-hq @github-actions
style: resolve style guide violations
8e18e10
@shahin-hq
refactor: remove expanded tables
a85293c
@shahin-hq
refactor: remove expanded tables
7ba788d
@shahin-hq
refactor: remove expanded tables
727c178
@shahin-hq
refactor: remove expanded tables
aeafd90
@shahin-hq
refactor: remove expanded tables
d1c0f2b
@shahin-hq
refactor: remove expanded tables
a2d6b5d
@shahin-hq
refactor: remove expanded tables
2128b44
@shahin-hq
refactor: remove expanded tables
9b2c4b0
@shahin-hq
refactor: remove expanded tables
ca56d68
@shahin-hq
refactor: remove expanded tables
0e0aad5
@shahin-hq
Merge remote-tracking branch 'origin/refactor/remove-expanded-tables'…
09f84c0 
… into refactor/remove-expanded-tables
@shahin-hq
refactor: remove expanded tables
1c6467d
@shahin-hq
Merge branch 'refs/heads/develop' into refactor/remove-expanded-tables
23354f3 
# Conflicts:
#	src/domains/transaction/components/TransactionTable/TransactionRow/PendingTransferRowMobile.tsx
#	src/domains/transaction/components/TransactionTable/TransactionRow/SignedTransactionRowMobile.tsx
@shahin-hq
refactor: remove expanded tables
89b9110
@shahin-hq
refactor: remove expanded tables
bc28e25
@shahin-hq
refactor: remove expanded tables
3fab4a7
@shahin-hq @github-actions
style: resolve style guide violations
34acf6f
@shahin-hq
refactor: remove expanded tables
e358a18
@shahin-hq
Merge remote-tracking branch 'origin/refactor/remove-expanded-tables'…
03e3ae1 
… into refactor/remove-expanded-tables
@shahin-hq
refactor: remove expanded tables
38d3ebe
@shahin-hq @github-actions
style: resolve style guide violations
e46b66e
@shahin-hq
refactor: remove expanded tables
8f0d66b
@goga-m
Copy link
Contributor

goga-m commented Sep 16, 2024 •
edited
Loading

@shahin-hq some snapshot conflicts after merging #646 😆

@shahin-hq
Merge branch 'refs/heads/develop' into refactor/delegate-registration…
c1deb17 
…-review-step

# Conflicts:
#	src/domains/transaction/components/DelegateRegistrationForm/__snapshots__/DelegateRegistrationForm.test.tsx.snap
#	src/domains/transaction/components/UnlockTokens/blocks/__snapshots__/UnlockTokensSummary.test.tsx.snap
#	src/domains/transaction/pages/SendDelegateResignation/__snapshots__/SendDelegateResignation.test.tsx.snap
#	src/domains/transaction/pages/SendIpfs/__snapshots__/SendIpfs.Encryption.test.tsx.snap
#	src/domains/transaction/pages/SendIpfs/__snapshots__/SendIpfs.test.tsx.snap
#	src/domains/transaction/pages/SendTransfer/__snapshots__/LedgerReview.test.tsx.snap
#	src/domains/transaction/pages/SendTransfer/__snapshots__/SendTransfer.Fees.test.tsx.snap
#	src/domains/transaction/pages/SendTransfer/__snapshots__/SendTransfer.test.tsx.snap
#	src/domains/transaction/pages/SendVote/__snapshots__/SendVote.test.tsx.snap
@shahin-hq
refactor: adjust review step for delegate registration
bc5b9e8
@shahin-hq
refactor: adjust review step for delegate registration
45bd912
@shahin-hq
refactor: adjust review step for delegate registration
a3ec5b2
@shahin-hq
refactor: adjust review step for delegate registration
e795910
@shahin-hq
refactor: adjust review step for delegate registration
60ffd6b
@shahin-hq
refactor: adjust review step for delegate registration
06a5694
@shahin-hq
refactor: adjust review step for delegate registration
b503b5b
@shahin-hq shahin-hq merged commit 75d70a4 into develop Sep 16, 2024
29 checks passed
@shahin-hq shahin-hq deleted the refactor/delegate-registration-review-step branch September 16, 2024 14:04
@ItsANameToo ItsANameToo added this to the 1.17.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goga-m goga-m goga-m left review comments

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahin-hq @goga-m @samharperpittam @ItsANameToo