Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ledger tables padding #637

Merged
merged 7 commits into from
Sep 4, 2024
Merged

refactor: ledger tables padding #637

merged 7 commits into from
Sep 4, 2024

Conversation

patricio0312rev
Copy link
Contributor

[ledger] adjust paddings and borders in import tables

Summary

  • Table padding and borders have been refactored to match the new designs.
  • TableWrapper styles have been refactored.

Screenshots

  • Skeleton scan table:
image
  • Wallet scan table:
image
  • Imported wallets table:
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Sep 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Sep 3, 2024 11:31pm

@patricio0312rev patricio0312rev mentioned this pull request Sep 3, 2024
Merged
6 tasks
@patricio0312rev patricio0312rev merged commit 3b4e640 into develop Sep 4, 2024
29 checks passed
@patricio0312rev patricio0312rev deleted the refactor/ledger-tables-padding branch September 4, 2024 10:47
@ItsANameToo ItsANameToo added this to the 1.17.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patricio0312rev @samharperpittam @ItsANameToo