Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: overview page header #631

Merged
merged 17 commits into from
Aug 29, 2024
Merged

refactor: overview page header #631

merged 17 commits into from
Aug 29, 2024

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Aug 29, 2024 •
edited
Loading

[wallet] adjust overview page: header

Summary

  • WalletHeader and WalletHeaderMobile components have been refactored to match new design.
  • New CopyAddress reusable component with the new animation for the copy icon.
  • Unit tests updated for the changes made.
  • Snapshots have been updated.
  • Icon list has been updated.

## Screenshots

  • 320px:
image
  • 640px:
image
  • 768px:
image
  • 1024px:
image
  • 1280px:
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Aug 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Aug 29, 2024 4:22pm

@patricio0312rev patricio0312rev marked this pull request as draft August 29, 2024 05:04
@patricio0312rev patricio0312rev marked this pull request as ready for review August 29, 2024 11:46
@ItsANameToo ItsANameToo merged commit 555eb8b into develop Aug 29, 2024
30 checks passed
@ItsANameToo ItsANameToo deleted the refactor/overview-page-header branch August 29, 2024 16:44
@ItsANameToo ItsANameToo added this to the 1.17.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patricio0312rev @ItsANameToo