Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: completed import Ledger page #619

Merged
merged 11 commits into from
Aug 20, 2024

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Aug 20, 2024

[ledger] adjust ledger import list & completed

Summary

  • New icon has been added.
  • Translation file has been updated.
  • New LedgerWalletImport.blocks file to store reusable components.
  • Ledger import completed page has been refactored to match the new designs. This includes both the dark/light mode and desktop/mobile views.
  • Single wallet import view has also been updated and refactored.

Screenshots

  • Mobile light view:
image
  • Desktop light view:
image
  • Desktop dark view:
image
  • Single wallet import desktop view:
image
  • Single wallet import mobile view:
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Aug 20, 2024 4:54am

@patricio0312rev patricio0312rev added this to the 1.17.0 milestone Aug 20, 2024
@ItsANameToo ItsANameToo merged commit c1cc57e into develop Aug 20, 2024
30 checks passed
@ItsANameToo ItsANameToo deleted the refactor/completed-import-ledger-page branch August 20, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants