refactor: implement my votes page design changes #618
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…-changes' into refactor/implement-my-votes-page-changes
…-changes' into refactor/implement-my-votes-page-changes
shahin-hq
requested review from
ItsANameToo,
samharperpittam,
goga-m,
boldninja and
alexbarnsley
as code owners
…-changes' into refactor/implement-my-votes-page-changes
| COVERAGE_THRESHOLD_BRANCHES: 98.48 | ||
| COVERAGE_THRESHOLD_LINES: 98.67 | ||
| COVERAGE_THRESHOLD_STATEMENTS: 98.73 | ||
| COVERAGE_THRESHOLD_BRANCHES: 98.35 |
There was a problem hiding this comment.
I can't really tell why it was failing due to coverage as it has matching values with a passing test:
Passing test from develop: https://github.com/ArdentHQ/arkvault/actions/runs/10486923172/job/29046217452
Failing test: https://github.com/ArdentHQ/arkvault/actions/runs/10486395863/job/29044533608
There was a problem hiding this comment.
the reason is that the thresholds depend on a variety of files. Now if you end up refactoring areas in these files, it's possible that the total amount of branches goes down for example. If you don't change the tests (other than removing the ones that are obsolete) it's possible that the coverage goes down because of the amount of branches remaining. Example:
- you have 11 lines of code, 10 are covered = 90.9% coverage
- you remove 1 covered line of code: 10 lines of code remaining, 9 are covered = 90% coverage
this doesn't mean that the code in itself has become less covered, as the exact same assertions are still being made to before, but because it's percentage based it does drop in overall coverage. This will always be a thing; only when we'd have 100% coverage everywhere would this not happen
| <tr key={key} {...headerGroupProps}> | ||
| {headerGroup.headers.map(renderColumn)} | ||
| </tr> | ||
| ); |
There was a problem hiding this comment.
This is to fix warning:
| ); | ||
| } | ||
|
|
||
| // @TODO handle multiple validators |
There was a problem hiding this comment.
Summary
Closes: https://app.clickup.com/t/86du08j9r
Checklist