Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: long memo overflow #616

Merged
merged 5 commits into from
Aug 16, 2024
Merged

fix: long memo overflow #616

merged 5 commits into from
Aug 16, 2024

Conversation

patricio0312rev
Copy link
Contributor

[transaction review] long memo overflow

Summary

  • Long memos will now break into multiple lines instead of overflowing the texts.
  • Snapshots for UTs have been updated.
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Aug 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Aug 15, 2024 9:20pm

@patricio0312rev patricio0312rev added this to the 1.17.0 milestone Aug 15, 2024
@ItsANameToo ItsANameToo merged commit 4cab130 into develop Aug 16, 2024
29 checks passed
@ItsANameToo ItsANameToo deleted the fix/long-memo-overflow branch August 16, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahin-hq shahin-hq shahin-hq approved these changes

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patricio0312rev @ItsANameToo @samharperpittam @shahin-hq