refactor: ledger address list #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
patricio0312rev
commented
Aug 14, 2024
.github/workflows/test.yml
Outdated
| @@ -841,7 +841,7 @@ jobs: | |||
| - name: Test | |||
| uses: nick-invision/retry@v2 | |||
| env: | |||
| COVERAGE_THRESHOLD_LINES: 99.93 | |||
| COVERAGE_THRESHOLD_LINES: 99.75 | |||
There was a problem hiding this comment.
Due to the components being refactored, this line needed to be updated. The lines missing tests are the same as before the PR 🤔
6 tasks
shahin-hq
reviewed
Aug 14, 2024
src/domains/wallet/pages/ImportWallet/Ledger/LedgerScanStep.blocks.test.tsx
Outdated
Show resolved
Hide resolved
samharperpittam
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Minor issue but the divider lines within the table header shouldn't exist. (next to checkbox and between Address and Balance)
Design
Implementation
Also, when the checkbox within the table header is unselected, it should be white. Can see the difference in the images above.
|
@samharperpittam @shahin-hq PR should be ready to review again ✅ |
samharperpittam
approved these changes
Aug 15, 2024
shahin-hq
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ledger] adjust address list
Summary
Addresscomponent has been refactored.Checklist