Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: select sender modal #602

Merged
merged 94 commits into from
Aug 8, 2024
Merged

refactor: select sender modal #602

merged 94 commits into from
Aug 8, 2024

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Aug 5, 2024 •
edited
Loading

[send] adjust sender selection modal

Summary

Screenshots

image image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

patricio0312rev and others added 30 commits August 2, 2024 12:05
@patricio0312rev
chore: update icons
e6adbeb
@patricio0312rev
chore: update icons
150a885
@patricio0312rev
chore: update translation files
859d372
@patricio0312rev
refactor: control button styls
593bd6e
@patricio0312rev
refactor: table styles
1c1d66d
@patricio0312rev
refactor: table cell
f1efba8
@patricio0312rev
refactor: header search bar
9d37dd5
@patricio0312rev
refactor: header search input
c2109de
@patricio0312rev
refactor: input height
8c37411
@patricio0312rev
refactor: modal paddings
c4afe5b
@patricio0312rev
feat: recipient item mobile
d841e0f
@patricio0312rev
refactor: search recipient
6b33416
@patricio0312rev
fix: eslint issues
dbf2e54
@patricio0312rev @github-actions
style: resolve style guide violations
d158d3a
@ItsANameToo @github-actions
style: resolve style guide violations
ceee471
@patricio0312rev
chore: update snapshots
47ddc7a
@patricio0312rev
Merge branch 'refactor/select-recipient-modal' of https://github.com/…
579bf8e 
…ArdentHQ/arkvault into refactor/select-recipient-modal
@patricio0312rev
chore: update snapshots
140e0cc
@patricio0312rev
chore: transaction domain snapshots
9cb4a3d
@patricio0312rev
chore: contact domain snapshots
1815154
@patricio0312rev
chore: update snapshots
ea0aac7
@patricio0312rev
chore: update snapshots
d77b0bd
@patricio0312rev
fix: transaction component test
d0a323e
@patricio0312rev
fix: line coverage
10fd669
@patricio0312rev @github-actions
style: resolve style guide violations
99cc337
@patricio0312rev
chore: update snapshots
aaef5d5
@patricio0312rev
Merge branch 'refactor/select-recipient-modal' of https://github.com/…
251d93f 
…ArdentHQ/arkvault into refactor/select-recipient-modal
@patricio0312rev
chore: update snapshots
8381cd3
@patricio0312rev
refactor: recipient list
f96181a
@patricio0312rev
refactor: recipient list
b69e971
patricio0312rev and others added 17 commits August 6, 2024 06:18
@patricio0312rev
fix: import alias
339ab1a
@patricio0312rev
fix: import alias
4422108
@patricio0312rev
Merge branch 'refactor/select-recipient-modal-component' into refacto…
b856779 
…r/select-recipient-modal
@patricio0312rev @github-actions
style: resolve style guide violations
50e9ca6
@patricio0312rev
fix: recipient alias value
1e2be27
@patricio0312rev @github-actions
style: resolve style guide violations
3670883
@patricio0312rev
Merge branch 'refactor/select-recipient-modal' of https://github.com/…
e103885 
…ArdentHQ/arkvault into refactor/select-recipient-modal
@patricio0312rev
Merge branch 'refactor/select-recipient-modal' of https://github.com/…
8875aa6 
…ArdentHQ/arkvault into refactor/select-recipient-modal
@patricio0312rev
chore: update snapshots
84be088
@patricio0312rev
wip
934fbd2
@patricio0312rev
wip
cf1176a
@patricio0312rev
Merge branch 'refactor/select-recipient-modal-component' into refacto…
1c1790b 
…r/select-recipient-modal
@patricio0312rev
wip
476bd95
@patricio0312rev
wip
884b028
@patricio0312rev
wip
929434b
@patricio0312rev
wip
9366dac
@patricio0312rev
Merge branch 'refactor/select-recipient-modal' into refactor/select-s…
d34c13a 
…ender-modal
Base automatically changed from refactor/select-recipient-modal to refactor/select-recipient-modal-component August 7, 2024 14:01
Base automatically changed from refactor/select-recipient-modal-component to develop August 7, 2024 14:39
@patricio0312rev patricio0312rev marked this pull request as ready for review August 7, 2024 14:39
goga-m
goga-m reviewed Aug 8, 2024
View reviewed changes
.github/workflows/test.yml Outdated
Comment on lines 846 to 847
COVERAGE_THRESHOLD_STATEMENTS: 99.39
COVERAGE_THRESHOLD_STATEMENTS: 99.38
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @patricio0312rev I think we have a duplicate here

@patricio0312rev patricio0312rev merged commit 906b195 into develop Aug 8, 2024
29 checks passed
@patricio0312rev patricio0312rev deleted the refactor/select-sender-modal branch August 8, 2024 14:26
@ItsANameToo ItsANameToo added this to the 1.17.0 milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goga-m goga-m goga-m approved these changes

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patricio0312rev @goga-m @ItsANameToo