Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: adjust ledger transaction review step #590

Merged
merged 14 commits into from
Jul 22, 2024
Merged

refactor: adjust ledger transaction review step #590

merged 14 commits into from
Jul 22, 2024

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 19, 2024 •
edited
Loading

Summary

Closes https://app.clickup.com/t/86dtzhc1r

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Jul 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Jul 19, 2024 4:28pm

@goga-m goga-m marked this pull request as ready for review July 19, 2024 16:35
@ItsANameToo ItsANameToo added this to the 1.17.0 milestone Jul 22, 2024
@ItsANameToo ItsANameToo merged commit b09f0a2 into develop Jul 22, 2024
56 of 58 checks passed
@ItsANameToo ItsANameToo deleted the feat/tx-review branch July 22, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goga-m @ItsANameToo