Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: send transfer page design changes #585

Merged
merged 40 commits into from
Jul 15, 2024

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Jul 12, 2024

Summary

Closes: https://app.clickup.com/t/86dtzg8k7
Design: https://www.figma.com/design/o6b1tEMOdUtHv7ijVs6pMX/ARKVault?node-id=13879-104403&m=dev

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Jul 15, 2024 8:14am

Copy link
Contributor

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the multipayment section has the address identicon again, while #583 removed it. Please have a look

@ItsANameToo ItsANameToo marked this pull request as draft July 15, 2024 08:24
@ItsANameToo ItsANameToo marked this pull request as ready for review July 15, 2024 09:48
@ItsANameToo
Copy link
Contributor

ignore, preview wasn't updated with the merge yet when I looked

@ItsANameToo ItsANameToo added this to the 1.17.0 milestone Jul 15, 2024
@ItsANameToo ItsANameToo merged commit ce526f7 into develop Jul 15, 2024
58 checks passed
@ItsANameToo ItsANameToo deleted the refactor/send-page-design-changes branch July 15, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants