chore: update eslint dependencies #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goga-m
requested review from
ItsANameToo,
samharperpittam,
boldninja and
alexbarnsley
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
goga-m
commented
Jul 4, 2024
Comment on lines
+263
to
+273
| // Disabling the following as they autofix ~900 files and will make conflict resolution hard. | ||
| // | ||
| // @TODO: Enable the following when merged in `feat/mainsail`. | ||
| // If tests are failing, can copy the fixes from https://github.com/ArdentHQ/arkvault/pull/558 | ||
| // as it contains all the fixes on tests & build errors. | ||
| "testing-library/await-async-events": "off", | ||
| "simple-import-sort/imports": "off", | ||
| "simple-import-sort/imports": "off", | ||
| "simple-import-sort/exports": "off", | ||
| "@typescript-eslint/no-duplicate-type-constituents": "off", | ||
| "unicorn/prefer-string-raw": "off", |
There was a problem hiding this comment.
Created a separate task to re-enable them https://app.clickup.com/t/86du1r0qb
goga-m
commented
Jul 4, 2024
Comment on lines
+146
to
+158
| it("should render ledger table in scanning mode", () => { | ||
| render( | ||
| <LedgerTable | ||
| wallets={[]} | ||
| selectedWallets={[]} | ||
| isScanningMore | ||
| isSelected={() => false} | ||
| network={profile.wallets().first().network()} | ||
| />, | ||
| ); | ||
| expect(screen.getByTestId("LedgerScanStep__scan-more")).toMatchSnapshot(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
This is just for coverage fix in wallet domain
goga-m
commented
Jul 4, 2024
Comment on lines
-3
to
+4
| /* eslint-disable import/no-relative-parent-imports */ | ||
| /* eslint-disable sonarjs/no-duplicate-string */ | ||
| /* eslint-disable import-alias/import-alias */ |
There was a problem hiding this comment.
import-alias/import-alias is now the equivalent rule for import/no-relative-parent-imports
goga-m
commented
Jul 4, 2024
Comment on lines
+32
to
+47
| ignores: [ | ||
| "build/", | ||
| "config-overrides.js", | ||
| "coverage/", | ||
| "dist/", | ||
| "vitest.setup.ts", | ||
| "public/", | ||
| "**/cucumber/**", | ||
| "**/e2e/**", | ||
| "scripts/", | ||
| "src/i18n", | ||
| "src/resources/*", | ||
| "src/tailwind.config.js", | ||
| "src/tests", | ||
| "*.d.ts", | ||
| ], |
There was a problem hiding this comment.
This replaces .eslintignore as it's no longer supported in eslint 9.
shahin-hq
approved these changes
Jul 4, 2024
6 tasks
patricio0312rev
approved these changes
Jul 5, 2024
ItsANameToo
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://app.clickup.com/t/86dty3n3a
Updates eslint and it's plugins to latest version and migrates configuration to flat config.
The main change is that we dropped
eslint-plugin-importthat had rules for the module import handling (ordering, path aliasing et.al) as it doesn't yet support eslint 9 import-js/eslint-plugin-import#2948 and we replaced it with alternative plugins that should do approx the same:Created a dedicated task to monitor & handle the plugin compatibility https://app.clickup.com/t/86du1dtca separately
Checklist