chore: remove babel dependencies #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
goga-m
commented
Jun 27, 2024
| "@cucumber/cucumber": "^9.3.0", | ||
| "@emotion/babel-plugin-jsx-pragmatic": "^0.2.0", |
There was a problem hiding this comment.
Handled by jsxImportSource property in vite config: https://github.com/ArdentHQ/arkvault/pull/547/files#diff-6a3b01ba97829c9566ef2d8dc466ffcffb4bdac08706d3d6319e42e0aa6890ddR74 `
goga-m
commented
Jun 27, 2024
| @@ -122,7 +116,6 @@ | |||
| "@vitejs/plugin-react": "^4.3.0", | |||
| "@vitest/coverage-istanbul": "0.24.5", | |||
| "autoprefixer": "^10.4.14", | |||
| "babel-plugin-macros": "^3.1.0", | |||
There was a problem hiding this comment.
This is unnecessary as we already use vite-plugin-babel-macros
goga-m
commented
Jun 27, 2024
Comment on lines
-99
to
-104
| "@babel/core": "^7.22.1", | ||
| "@babel/plugin-transform-react-jsx": "^7.24.6", | ||
| "@babel/preset-env": "^7.22.2", | ||
| "@babel/preset-react": "^7.22.3", | ||
| "@babel/preset-typescript": "^7.21.0", |
There was a problem hiding this comment.
@vitejs/plugin-react already handles jsx transformations
goga-m
changed the title
goga-m
requested review from
ItsANameToo,
samharperpittam,
boldninja and
alexbarnsley
as code owners
goga-m
force-pushed
the
chore/remove-babel
branch
from
007840a to
67c706a
Compare
shahin-hq
approved these changes
Jun 27, 2024
patricio0312rev
approved these changes
Jun 27, 2024
ItsANameToo
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://app.clickup.com/t/86dtxna83
Checklist