Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update testing library dependencies #545

Merged
merged 111 commits into from
Aug 19, 2024
Merged

fix: update testing library dependencies #545

merged 111 commits into from
Aug 19, 2024

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Jun 26, 2024 •
edited by ItsANameToo
Loading

[vault] Update @testing-library dependencies

Summary

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Jun 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Aug 19, 2024 0:05am

@patricio0312rev
Copy link
Contributor Author

As mentioned in the ticket, many of the snapshots and tests have broken due to the update. This PR can serve as the base PR for the entire refactor of the UTs

@ItsANameToo ItsANameToo added this to the 1.16.0 milestone Jun 28, 2024
@patricio0312rev patricio0312rev force-pushed the fix/update-testing-library-deps branch from bebce82 to cf1aaa5 Compare July 1, 2024 18:43
@ItsANameToo ItsANameToo marked this pull request as draft August 16, 2024 13:19
@ItsANameToo
Copy link
Contributor

draft until #611 is merged into it

@ItsANameToo ItsANameToo marked this pull request as ready for review August 19, 2024 10:21
@ItsANameToo
Copy link
Contributor

snapshot conflicts @patricio0312rev

@goga-m goga-m merged commit fea92ae into develop Aug 19, 2024
29 checks passed
@goga-m goga-m deleted the fix/update-testing-library-deps branch August 19, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahin-hq shahin-hq shahin-hq approved these changes

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@goga-m goga-m goga-m approved these changes

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patricio0312rev @goga-m @ItsANameToo @shahin-hq