fix: prevent sanitizing issues on currency input #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsobries
requested review from
ItsANameToo,
samharperpittam,
goga-m,
boldninja and
alexbarnsley
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
patricio0312rev
approved these changes
Apr 22, 2024
samharperpittam
approved these changes
Apr 23, 2024
shahin-hq
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue described on ticket is caused by the value being sanitized while typing, the adjustment applies the decimals limit sanitization until input is blurred
Other than testing, ensure that this does not cause any side-effect on other places when the currency input is used
https://app.clickup.com/t/86dtace5v
Checklist