Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add passphrase confirmation boxes #474

Merged
merged 35 commits into from
Apr 24, 2024
Merged

refactor: add passphrase confirmation boxes #474

merged 35 commits into from
Apr 24, 2024

Conversation

alfonsobries
Copy link
Contributor

@alfonsobries alfonsobries commented Apr 18, 2024 •
edited
Loading

Summary

Closes https://app.clickup.com/t/86dt573wc

Keep in mind that it also affect the second signature registration mnemonic validation

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Apr 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Apr 24, 2024 2:19pm

@alfonsobries alfonsobries marked this pull request as draft April 18, 2024 19:07
@goga-m
Copy link
Contributor

goga-m commented Apr 19, 2024

@alfonsobries there is a test failing on the generated mnemonic confirmation step 🤔 https://github.com/ArdentHQ/arkvault/actions/runs/8756249061/job/24032319415?pr=474#step:10:53

samharperpittam
samharperpittam requested changes Apr 23, 2024
View reviewed changes
Copy link

@samharperpittam samharperpittam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfonsobries - This is all looking good other than I was wondering if we could change the "wrong word" error message to "Incorrect word entered".

@alfonsobries
Copy link
Contributor Author

@samharperpittam ✅

@samharperpittam
Copy link

@samharperpittam ✅

You sure? @alfonsobries :D

@ItsANameToo ItsANameToo marked this pull request as draft April 24, 2024 09:39
@ItsANameToo ItsANameToo marked this pull request as ready for review April 24, 2024 14:17
@ItsANameToo ItsANameToo added this to the 1.15.0 milestone Apr 24, 2024
@ItsANameToo ItsANameToo merged commit 17f939c into develop Apr 24, 2024
40 of 57 checks passed
@ItsANameToo ItsANameToo deleted the feat/mnemonic-validation-input branch April 24, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@alfonsobries @goga-m @samharperpittam @ItsANameToo @shahin-hq