Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send transfer form amount validation #466

Merged
merged 8 commits into from
Apr 19, 2024
Merged

fix: send transfer form amount validation #466

merged 8 commits into from
Apr 19, 2024

Conversation

alfonsobries
Copy link
Contributor

@alfonsobries alfonsobries commented Apr 16, 2024 •
edited
Loading

Summary

https://app.clickup.com/t/86dt9cv8k

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Apr 19, 2024 3:18pm

@ItsANameToo ItsANameToo marked this pull request as draft April 18, 2024 07:57
@ItsANameToo ItsANameToo added this to the 1.15.0 milestone Apr 18, 2024
@ItsANameToo
Copy link
Contributor

@alfonsobries please have a look at the failing workflows

@alfonsobries
Copy link
Contributor Author

@ItsANameToo ✅

@alfonsobries alfonsobries marked this pull request as ready for review April 19, 2024 15:48
@goga-m goga-m merged commit d0fe595 into develop Apr 19, 2024
57 checks passed
@goga-m goga-m deleted the fix/amount-validation-timing branch April 19, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@goga-m goga-m goga-m approved these changes

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alfonsobries @ItsANameToo @goga-m