Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increasing custom fees available balance #420

Merged
merged 5 commits into from
Apr 9, 2024
Merged

fix: increasing custom fees available balance #420

merged 5 commits into from
Apr 9, 2024

Conversation

alfonsobries
Copy link
Contributor

Summary

Close https://app.clickup.com/t/86dt3t18h

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Apr 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Apr 8, 2024 11:08pm

@github-actions github-actions bot added the bugfix label Apr 3, 2024
ItsANameToo
ItsANameToo requested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfonsobries please add a test for the scenario this fixes, to make sure it works as intended going forward

@ItsANameToo ItsANameToo marked this pull request as draft April 8, 2024 08:21
@alfonsobries
Copy link
Contributor Author

@ItsANameToo ✅

@alfonsobries alfonsobries marked this pull request as ready for review April 8, 2024 22:50
@ItsANameToo ItsANameToo merged commit ce1ee0f into develop Apr 9, 2024
16 of 27 checks passed
@ItsANameToo ItsANameToo deleted the fix/available-balance-fee-issue branch April 9, 2024 09:42
@ItsANameToo ItsANameToo added this to the 1.15.0 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alfonsobries @ItsANameToo