Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: input stepper decrementing issues #419

Merged
merged 4 commits into from
Apr 9, 2024
Merged

fix: input stepper decrementing issues #419

merged 4 commits into from
Apr 9, 2024

Conversation

alfonsobries
Copy link
Contributor

Summary

Closes https://app.clickup.com/t/86dt3t15h

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Apr 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ❌ Failed (Inspect) Apr 8, 2024 11:05pm

@github-actions github-actions bot added the bugfix label Apr 2, 2024
ItsANameToo
ItsANameToo requested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfonsobries please add a test for the issue it resolves

@ItsANameToo ItsANameToo marked this pull request as draft April 8, 2024 08:20
@alfonsobries
Copy link
Contributor Author

@ItsANameToo done

@alfonsobries alfonsobries marked this pull request as ready for review April 8, 2024 18:14
@alfonsobries alfonsobries force-pushed the fix/small-number-steps branch from aca15c1 to c37caf7 Compare April 8, 2024 23:43
@ItsANameToo ItsANameToo merged commit 82a2994 into develop Apr 9, 2024
30 of 53 checks passed
@ItsANameToo ItsANameToo deleted the fix/small-number-steps branch April 9, 2024 09:41
@ItsANameToo ItsANameToo added this to the 1.15.0 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alfonsobries @ItsANameToo