Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to node v18.12.1 LTS #406

Merged
merged 44 commits into from
Jul 31, 2023
Merged

chore: upgrade to node v18.12.1 LTS #406

merged 44 commits into from
Jul 31, 2023

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 26, 2023

Closes https://app.clickup.com/t/861mx73d2

Summary

  • Requires node >=18.12.1 LTS
  • Packages updated to latest versions: gherkin-testcafe vitest vite react-idle-timer @cucumber/cucumber eslint
  • We updated the package for auto-signout, so it would be nice to double-check that aspect.
  • Some tests were timing out with password-protected profile login. As it only happened in tests, we shouldn't have any issues. Tested in the app and password-protected profile are able to login without issues (and see errors if password is incorrect). Another look at that would be great though to ensure all scenarios are covered.

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel
Copy link

vercel bot commented Jul 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Jul 28, 2023 4:45pm

@goga-m goga-m changed the title chore: upgrade to node v18 chore: upgrade to node v18.17.0 LTS Jul 28, 2023
@goga-m goga-m changed the title chore: upgrade to node v18.17.0 LTS chore: upgrade to node LTS 18.12.1 Jul 28, 2023
@goga-m goga-m changed the title chore: upgrade to node LTS 18.12.1 chore: upgrade to node v18.12.1 LTS Jul 28, 2023
@ItsANameToo ItsANameToo merged commit 7a78607 into develop Jul 31, 2023
@ItsANameToo ItsANameToo deleted the chore/node-v18 branch July 31, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants