Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Table Request - Add "bulb" part name #7805

Closed
7 of 8 tasks
WaigePilson opened this issue May 22, 2024 · 13 comments
Closed
7 of 8 tasks

Code Table Request - Add "bulb" part name #7805

WaigePilson opened this issue May 22, 2024 · 13 comments
Labels
Function-CodeTables Priority-High (Needed for work) High because this is causing a delay in important collection work..

Comments

@WaigePilson
Copy link

WaigePilson commented May 22, 2024

Goal

Add "bulb" as a part name

Context

Currently, the part names table contains just a handful of terms appropriate for describing plant parts: branch, bud, cone, flower, fruit, gall, leaf, pollen, rhizolith, rhizome, root, seed, spore, stem, and whole organism.

Similar to a rhizome, a bulb is a modified underground stem, in this case with modified leaves used for food storage. It would be appropriate to add bulb as another modified underground stem.

Table

https://arctos.database.museum/info/ctDocumentation.cfm?table=ctspecimen_part_name

Proposed Value

bulb

Proposed Definition

A modified subterranean plant stem usually consisting of a relatively large, usually globe-shaped structure of modified stem and fleshy leaves that functions as food storage organs during dormancy.

Priority

High, needed for importing of some UBWM:PB records

Helpful Actions

  • Add the issue to the Code Table Management Project.

  • Please reach out to anyone who might be affected by this change. Leave a comment or add this to the Committee agenda if you believe more focused conversation is necessary.

@ArctosDB/arctos-code-table-administrators @camwebb @Nicole-Ridgwell-NMMNHS

Approval

All of the following must be checked before this may proceed.

The How-To Document should be followed. Pay particular attention to terminology (with emphasis on consistency) and documentation (with emphasis on functionality). No person should act in multiple roles; the submitter cannot also serve as a Code Table Administrator, for example.

  • Code Table Administrator[1] - check and initial, comment, or thumbs-up to indicate that the request complies with the how-to documentation and has your approval
  • Code Table Administrator[2] - check and initial, comment, or thumbs-up to indicate that the request complies with the how-to documentation and has your approval
  • DBA - The request is functionally acceptable. The term is not a functional duplicate, and is compatible with existing data and code.
  • DBA - Appropriate code or handlers are in place as necessary. (ID_References, Media Relationships, Encumbrances, etc. require particular attention)

Rejection

If you believe this request should not proceed, explain why here. Suggest any changes that would make the change acceptable, alternate (usually existing) paths to the same goals, etc.

  1. Can a suitable solution be found here? If not, proceed to (2)
  2. Can a suitable solution be found by Code Table Committee discussion? If not, proceed to (3)
  3. Take the discussion to a monthly Arctos Working Group meeting for final resolution.

Implementation

Once all of the Approval Checklist is appropriately checked and there are no Rejection comments, or in special circumstances by decree of the Arctos Working Group, the change may be made.

  • Review everything one last time. Ensure the How-To has been followed. Ensure all checks have been made by appropriate personnel.

  • Add or revise the code table term/definition as described above. Ensure the URL of this Issue is included in the definition. URLs should be included as text, separated by spaced pipes. Do not include HTML in definitions.

Close this Issue.

DO NOT modify Arctos Authorities in any way before all points in this Issue have been fully addressed; data loss may result.

Special Exemptions

In very specific cases and by prior approval of The Committee, the approval process may be skipped, and implementation requirements may be slightly altered. Please note here if you are proceeding under one of these use cases.

  1. Adding an existing term to additional collection types may proceed immediately and without discussion, but doing so may also subject users to future cleanup efforts. If time allows, please review the term and definition as part of this step.
  2. The Committee may grant special access on particular tables to particular users. This should be exercised with great caution only after several smooth test cases, and generally limited to "taxonomy-like" data such as International Commission on Stratigraphy terminology.
@Jegelewicz Jegelewicz added the Priority-High (Needed for work) High because this is causing a delay in important collection work.. label May 22, 2024
@Jegelewicz Jegelewicz added this to the Needs Discussion milestone May 22, 2024
@camwebb
Copy link

camwebb commented May 22, 2024

👍 from me

@dustymc
Copy link
Contributor

dustymc commented May 22, 2024

I'm not at all clear how this lines up with https://docs.google.com/document/d/1mTWY6HRlC3TSrAb38W2HOQHiVO2F1tA1m5jaLstYMS8/edit#heading=h.w0tvdqpqd23q, or if that's still the direction we want to lean (seems a few decisions have gone the other way after that was discussed!). If we're trying to push flipper and hand and paw and .... into limb (are we? I'm lost there too!) then should this be - uhh, leaf? (And a modifier?)

Is there an ontology/authority/some sort of big-picture guidance for this sort of thing?

@ArctosDB/arctos-code-table-administrators help!

@WaigePilson
Copy link
Author

I'm not at all clear how this lines up with https://docs.google.com/document/d/1mTWY6HRlC3TSrAb38W2HOQHiVO2F1tA1m5jaLstYMS8/edit#heading=h.w0tvdqpqd23q, or if that's still the direction we want to lean (seems a few decisions have gone the other way after that was discussed!). If we're trying to push flipper and hand and paw and .... into limb (are we? I'm lost there too!) then should this be - uhh, leaf? (And a modifier?)

I'm fine with us moving "rhizome" as a part_modifier (of part "root") and then putting "bulb" as another part_modifier. However, so long as "rhizome" is a part name, I think that "bulb" should also be for the sake of consistency.

I've got no strong preference, I just need this added so I can import my collection!

Is there an ontology/authority/some sort of big-picture guidance for this sort of thing?

great question! I don't know of one off the top of my head, perhaps a modern botanist would have a better idea...

@dustymc
Copy link
Contributor

dustymc commented May 22, 2024

I'm not sure I have much of a preference either, other than wishing I had some [yep | nope ] that [ is | ain't ] a part formula...


 guid_prefix | count 
-------------+-------
 NMMNH:Paleo |     2

@Nicole-Ridgwell-NMMNHS any preferences/direction/whatever here?

@mkoo
Copy link
Member

mkoo commented May 25, 2024

I'm not at all clear how this lines up with https://docs.google.com/document/d/1mTWY6HRlC3TSrAb38W2HOQHiVO2F1tA1m5jaLstYMS8/edit#heading=h.w0tvdqpqd23q, or if that's still the direction we want to lean (seems a few decisions have gone the other way after that was discussed!). If we're trying to push flipper and hand and paw and .... into limb (are we? I'm lost there too!) then should this be - uhh, leaf? (And a modifier?)

I'm fine with us moving "rhizome" as a part_modifier (of part "root") and then putting "bulb" as another part_modifier. However, so long as "rhizome" is a part name, I think that "bulb" should also be for the sake of consistency.

I think this if you're ok with this where root has part_modifiers of rhizome and bulb then this would best fit the overall goals and inclinations of the Arctos CT

I've got no strong preference, I just need this added so I can import my collection!

Agreed! you just need to get to work!

If we could get input from affected collections (@Nicole-Ridgwell-NMMNHS )?

@Jegelewicz
Copy link
Member

@Jegelewicz
Copy link
Member

Above indicates this isn't a root?

[Inferred is_a relation] BFO:0000002 continuant
[Inferred is_a relation] BFO:0000001 entity
[Inferred is_a relation] BFO:0000004 independent continuant
[Inferred is_a relation] BFO:0000040 material entity
[Inferred is_a relation] PO:0025131 plant anatomical entity
[Inferred is_a relation] PO:0009011 plant structure
[Inferred is_a relation] PO:0025497 collective plant structure
[Inferred is_a relation] PO:0025007 collective plant organ structure
[is_a relation] PO:0009006 shoot system
[Current term] PO:0025356 bulb

@campmlc
Copy link

campmlc commented May 29, 2024

Bulbs are underground stems modified to store resources. . But there is a big difference between a bulb and an aboveground stem from a host of biological and management perspectives. Perhaps this should be its own term.
https://en.m.wikipedia.org/wiki/Bulb

@Nicole-Ridgwell-NMMNHS
Copy link

The issue with rhizome and bulb is that there is not an good "higher level" part that could be used. I think bulb should be its own term.

@campmlc
Copy link

campmlc commented Jun 5, 2024

Agree. I checked a box.

@mkoo
Copy link
Member

mkoo commented Jun 6, 2024

CT committee discussed and we agree that we should add bulb-- it does not create problems overall and will allow cataloging to move forward.

@dustymc
Copy link
Contributor

dustymc commented Jun 6, 2024

See #7737, would very much like big-picture guidance.

@Jegelewicz
Copy link
Member

added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Function-CodeTables Priority-High (Needed for work) High because this is causing a delay in important collection work..
Projects
None yet
Development

No branches or pull requests

7 participants