Skip to content

Conversation

Archmonger
Copy link
Owner

@Archmonger Archmonger commented Dec 10, 2022

Type of PR (feature, enhancement, bug fix, etc.)

Description

Python 3.6 is currently EOL, and thus no longer needs testing.

Why should this be added

Fixes tests due to 3.6 docker containers no longer being made.

Checklist

  • Documentation has been added or amended for this feature / update

@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #472 (1931901) into master (040a63e) will decrease coverage by 1.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   92.15%   91.12%   -1.04%     
==========================================
  Files          16       19       +3     
  Lines         676      856     +180     
  Branches      141      144       +3     
==========================================
+ Hits          623      780     +157     
- Misses         30       41      +11     
- Partials       23       35      +12     
Impacted Files Coverage Δ
dbbackup/utils.py 86.89% <0.00%> (ø)
dbbackup/__init__.py 77.77% <0.00%> (ø)
dbbackup/settings.py 92.30% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Archmonger
Copy link
Owner Author

Can't fix this without

😠

@jezdez
Copy link

jezdez commented Dec 12, 2022

@Archmonger This is unblocked.

@Archmonger Archmonger merged commit 8071d26 into Archmonger:master Dec 12, 2022
@Archmonger Archmonger deleted the drop-py36 branch December 12, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants