Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DKC3 - Logic Softlock Fix #817

Merged
merged 46 commits into from
Jul 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
833c5d4
Baseline patching and logic for DKC3
PoryGone Jun 23, 2022
26603ab
Client can send, but not yet receive
PoryGone Jun 28, 2022
e504263
Alpha Test Baseline
PoryGone Jul 8, 2022
0d6a18b
Bug Fixes and Starting Lives Option
PoryGone Jul 11, 2022
dbbca1a
Finish BBH, add world hints
PoryGone Jul 12, 2022
4de21c5
Add music shuffle
PoryGone Jul 13, 2022
349bd57
Boomer Costs Text
PoryGone Jul 16, 2022
b22f5e5
Stubbed in Collect behaviour
PoryGone Jul 16, 2022
41a9956
Adjust Gyrocopter option
PoryGone Jul 16, 2022
04edebb
Add Bonus Coin junk replacement and tracker support
PoryGone Jul 18, 2022
73dd868
Delete bad logs
PoryGone Jul 19, 2022
a567821
Undo host.yaml change
PoryGone Jul 19, 2022
1b52cc5
Merge pull request #1 from PoryGoneDev/dkc3-client-init
PoryGone Jul 19, 2022
ead7df5
Merge branch 'main' into dkc3-main
PoryGone Jul 19, 2022
ff8e100
Refactored SNIClient
PoryGone Jul 19, 2022
65e1511
Make Swanky Free
PoryGone Jul 20, 2022
4cd199e
Fix Typo
PoryGone Jul 20, 2022
050eb20
Undo SNIClient run_game hack
PoryGone Jul 20, 2022
febb658
Fix Typo
PoryGone Jul 20, 2022
c979fb0
Merge pull request #2 from PoryGoneDev/dkc3-client-refactor
PoryGone Jul 20, 2022
4d4f6c5
Remove Bosses from Level Shuffle
PoryGone Jul 20, 2022
5d1e262
Remove duplicate kivy Data
PoryGone Jul 20, 2022
5ad9706
Add DKC3 Docs and increment Data version
PoryGone Jul 20, 2022
fea2286
Remove dead code
PoryGone Jul 20, 2022
5fd8436
Fix mislabeled region
PoryGone Jul 20, 2022
b880da6
Merge branch 'main' into dkc3-main
PoryGone Jul 20, 2022
ac8b655
Add Dark Souls 3 to README
PoryGone Jul 20, 2022
97946ea
Always force Cog on Rocket Rush Flag
PoryGone Jul 21, 2022
3616b02
Fix Single Ski lock and too many DK Coins
PoryGone Jul 21, 2022
0e48b1e
Update Retroarch version number
PoryGone Jul 21, 2022
6da2a0d
Don't send DKC3 through LttP Adjuster
PoryGone Jul 21, 2022
0bd1ed4
Comment Location ROM Table
PoryGone Jul 21, 2022
b60527a
Change ROM Hash prefix to D3
PoryGone Jul 21, 2022
1b5048e
Remove redundant constructor
PoryGone Jul 21, 2022
494e4bd
Add ROM Change Safeguards
PoryGone Jul 21, 2022
8848ea9
Properly mark WRAM accesses
PoryGone Jul 21, 2022
2d6a522
Remove outdated region connect
PoryGone Jul 21, 2022
ae4736b
Fix syntax error
PoryGone Jul 21, 2022
b3273d1
Fix Game description
PoryGone Jul 21, 2022
02c8f0b
Fix SNES Bank Access
PoryGone Jul 21, 2022
bccaff0
Add isso_setup for DKC3
PoryGone Jul 22, 2022
b93503e
Double Quote strings
PoryGone Jul 22, 2022
948dacb
Escape single quotes I guess
PoryGone Jul 22, 2022
3760f21
Merge branch 'main' into dkc3-main
PoryGone Jul 22, 2022
74c28b2
Add two locations to Trade Sequence List
PoryGone Jul 24, 2022
05bddd5
Remove trace sequence locations from ROM data dict
PoryGone Jul 24, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions worlds/dkc3/Regions.py
Original file line number Diff line number Diff line change
Expand Up @@ -501,9 +501,11 @@ def create_regions(world, player: int, active_locations):
bounty_bay_region = create_region(world, player, active_locations, LocationName.bounty_bay_region,
bounty_bay_region_locations, None)

sky_high_secret_region_locations = {
LocationName.sky_high_secret: [0x64B, 1],
}
sky_high_secret_region_locations = {}
if False:#world.include_trade_sequence[player]:
sky_high_secret_region_locations.update({
LocationName.sky_high_secret: [0x64B, 1],
})
sky_high_secret_region = create_region(world, player, active_locations, LocationName.sky_high_secret_region,
sky_high_secret_region_locations, None)

Expand All @@ -513,9 +515,11 @@ def create_regions(world, player: int, active_locations):
glacial_grotto_region = create_region(world, player, active_locations, LocationName.glacial_grotto_region,
glacial_grotto_region_locations, None)

cifftop_cache_region_locations = {
LocationName.cifftop_cache: [0x64D, 1],
}
cifftop_cache_region_locations = {}
if False:#world.include_trade_sequence[player]:
cifftop_cache_region_locations.update({
LocationName.cifftop_cache: [0x64D, 1],
})
cifftop_cache_region = create_region(world, player, active_locations, LocationName.cifftop_cache_region,
cifftop_cache_region_locations, None)

Expand Down
4 changes: 2 additions & 2 deletions worlds/dkc3/Rom.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,9 +238,9 @@
0xDC30AF: [0x648, 1],
0xDC30B0: [0x649, 1],
0xDC30B1: [0x64A, 1],
0xDC30B2: [0x64B, 1],
#0xDC30B2: [0x64B, 1], # Disabled until Trade Sequence
0xDC30B3: [0x64C, 1],
0xDC30B4: [0x64D, 1],
#0xDC30B4: [0x64D, 1], # Disabled until Trade Sequence
0xDC30B5: [0x64E, 1],

0xDC30B6: [0x5FD, 4], # Banana Bird Mother
Expand Down
4 changes: 2 additions & 2 deletions worlds/dkc3/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def generate_basic(self):
itempool: typing.List[DKC3Item] = []

# Levels
total_required_locations = 161
total_required_locations = 159

number_of_banana_birds = 0
# Rocket Rush Cog
Expand All @@ -105,7 +105,7 @@ def generate_basic(self):

## Brothers Bear
if False:#self.world.include_trade_sequence[self.player]:
total_required_locations += 8
total_required_locations += 10

number_of_bonus_coins = (self.world.krematoa_bonus_coin_cost[self.player] * 5)
number_of_bonus_coins += math.ceil((85 - number_of_bonus_coins) * self.world.percentage_of_extra_bonus_coins[self.player] / 100)
Expand Down