Core: Include unfilled locations in error when there are not enough locations for progression items #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScipioWright
added
the
is: documentation
github-actions
bot
added
affects: core
Exempt-Medic
reviewed
Dec 9, 2024
Exempt-Medic
approved these changes
Dec 9, 2024
Co-authored-by: Exempt-Medic <[email protected]>
Exempt-Medic
added
waiting-on: core-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Have it output which locations are unfilled when you get this specific fill error.
For the specific issue I was having, this change made it very clear very quickly what was wrong here (a region connection that couldn't be fulfilled).
How was this tested?
Test gen with the name of an event item changed.