Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Witness: Allow setting the puzzle randomization seed yourself #4196

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented Nov 16, 2024

Someone requested this

I realized it would take like 5 minutes

So here it is :)

Depends on #4197 because Range options can't use default: "random" right now.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Nov 16, 2024
@NewSoupVi NewSoupVi added the is: enhancement Issues requesting new features or pull requests implementing new features. label Nov 16, 2024
@NewSoupVi NewSoupVi added the waiting-on: other Issue/PR is waiting for something else, like another PR. label Nov 16, 2024
@NewSoupVi NewSoupVi removed the waiting-on: other Issue/PR is waiting for something else, like another PR. label Nov 17, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I've tested the exact same change on my own before

@Exempt-Medic Exempt-Medic removed the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Nov 18, 2024
@NewSoupVi NewSoupVi merged commit 9c102da into ArchipelagoMW:main Nov 18, 2024
18 checks passed
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
…chipelagoMW#4196)

* Allow setting the puzzle randomization seed yourself

* longer tooltip

* Oh

* Also actually have the correct values that the client will accept (lol, thanks Medic)

* Update worlds/witness/options.py

Co-authored-by: Exempt-Medic <[email protected]>

---------

Co-authored-by: Exempt-Medic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants