Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pokemon Emerald: Add some warnings to option descriptions #4114

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Pokemon Emerald: Add some warnings to option descriptions #4114

merged 1 commit into from
Oct 28, 2024

Conversation

Zunawe
Copy link
Collaborator

@Zunawe Zunawe commented Oct 28, 2024 •
edited
Loading

What is this fixing or adding?

Adds some notes to a few option descriptions to help clarify player expectations.

Addresses #3945

How was this tested?

Reading

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Oct 28, 2024
ScipioWright
ScipioWright approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider stating how many locations they add in the description -- it's helpful in decision making for stuff like this.

@ScipioWright ScipioWright added the is: documentation Improvements or additions to documentation. label Oct 28, 2024
@Zunawe
Copy link
Collaborator Author

Zunawe commented Oct 28, 2024

Yeah, I was considering that when doing this, but figured it's not the point of this particular PR. I'll have to settle on the specific format I find most appealing. But it is on my mind as something that's probably helpful.

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Oct 28, 2024
@NewSoupVi NewSoupVi merged commit f10eb85 into ArchipelagoMW:main Oct 28, 2024
18 checks passed
@Zunawe Zunawe deleted the emerald-option-warn branch October 28, 2024 22:32
@nicholassaylor
Copy link
Contributor

Is this meant to close #3945 ?

@Zunawe
Copy link
Collaborator Author

Zunawe commented Oct 29, 2024

Yeah, I edited the original post a couple seconds after creating it to include it

AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
@Zunawe @AustinSumigray
Pokemon Emerald: Add some warnings to option descriptions (Archipelag…
fb0fb0f 
…oMW#4114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScipioWright ScipioWright ScipioWright approved these changes

@NewSoupVi NewSoupVi NewSoupVi approved these changes

Assignees
No one assigned
Labels
is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zunawe @nicholassaylor @ScipioWright @NewSoupVi