macos: fix crash when 'Open Patch' is used #4108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
black-sliver
added
the
is: bug/fix
github-actions
bot
added
affects: core
Berserker66
approved these changes
Oct 28, 2024
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
* macos: fix crash when 'Open Patch' is used * Utils: fix error message in open_directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
On macos, when kivy handles the GUI of the process, trying to instantiate tk will crash.
This spawns tk in multiprocessing for open_filename and open_directory if tk is required.
Fixes [Launcher] Open Patch button crashing (MacOS).
Note: even if we had plyer, there are edge cases that are not handled well by it, so the tk code is likely gonna stay. More on that in the linked discord thread.
How was this tested?
https://discord.com/channels/731205301247803413/1277050370756972596/1300051092603797619