Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: fix item links for alternate menu regions #4097

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

qwint
Copy link
Collaborator

@qwint qwint commented Oct 26, 2024

What is this fixing or adding?

not assume origin is Menu in Groups
vi made me do it

How was this tested?

two link everything factorios

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Oct 26, 2024
Copy link
Member

@NewSoupVi NewSoupVi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good girl :)

@NewSoupVi NewSoupVi merged commit af77b76 into ArchipelagoMW:main Oct 26, 2024
18 checks passed
@qwint qwint deleted the core_itemlink_start branch October 26, 2024 04:00
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants