Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup: SNI: separate win7/non-win7 build, update macos naming #4088

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Setup: SNI: separate win7/non-win7 build, update macos naming #4088

merged 2 commits into from
Oct 26, 2024

Conversation

black-sliver
Copy link
Member

@black-sliver black-sliver commented Oct 24, 2024 •
edited
Loading

What is this fixing or adding?

Downloads a working version of SNI

How was this tested?

Not yet, waiting for alttpo/sni#43

Seeing

Downloaded SNI from https://github.com/alttpo/sni/releases/download/v0.0.98/sni-v0.0.98-windows7-amd64.zip

in github action

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Oct 24, 2024
@black-sliver black-sliver marked this pull request as draft October 24, 2024 20:57
@black-sliver black-sliver marked this pull request as ready for review October 24, 2024 23:03
@black-sliver black-sliver force-pushed the setup-win7 branch 2 times, most recently from a970e7c to 23f742d Compare October 25, 2024 01:04
@black-sliver black-sliver added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. affects: release/blocker Issues/PRs that must be addressed before next official release. labels Oct 26, 2024
@black-sliver black-sliver merged commit d61a76f into ArchipelagoMW:main Oct 26, 2024
12 checks passed
@black-sliver black-sliver deleted the setup-win7 branch October 26, 2024 22:28
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
@black-sliver @AustinSumigray
Setup: SNI: separate win7/non-win7 build, update macos naming (Archip…
5dc96a4 
…elagoMW#4088)

* Setup: fix macos SNI download name

* Setup: prefer SNI Windows7 build on py3.8, non-7 on py3.9+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. affects: release/blocker Issues/PRs that must be addressed before next official release. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@black-sliver @Berserker66