Stardew Valley: Make progressive movie theater a progression trap #3985
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiple classifications in our csvs
github-actions
bot
added
the
waiting-on: peer-review
agilbert1412
added
the
is: enhancement
EmilyV99
approved these changes
Sep 22, 2024
agilbert1412
added
waiting-on: core-review
Jouramie
approved these changes
Sep 23, 2024
Berserker66
reviewed
Nov 26, 2024
| @@ -8,5 +8,5 @@ class TestHasProgressionPercent(unittest.TestCase): | |||
| def test_max_item_amount_is_full_collection(self): | |||
| # Not caching because it fails too often for some reason | |||
| with solo_multiworld(world_caching=False) as (multiworld, world): | |||
| progression_item_count = sum(1 for i in multiworld.get_items() if ItemClassification.progression in i.classification) | |||
| progression_item_count = sum(1 for i in multiworld.get_items() if i.classification & ItemClassification.progression) | |||
There was a problem hiding this comment.
This technically didn't need changing, in works just fine.
Berserker66
approved these changes
Nov 26, 2024
Jouramie
pushed a commit
to agilbert1412/Archipelago
that referenced
this pull request
Dec 15, 2024
…chipelagoMW#3985) (cherry picked from commit 7562404)
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Alow our csvs to handle multiple classification, and then classified the Movie Theater as "Progression Trap" as this is how the community already views it anyway
How was this tested?
Unit Tests