-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AHIT: Fix moderate logic rules using add_rule instead of set_rule #3850
AHIT: Fix moderate logic rules using add_rule instead of set_rule #3850
Conversation
The moderate logic for the Mafia Town Clock Tower Chest and Top of Ruined Tower with nothing, and for clearing Rock the Boat without Ice Hat were mistakenly using `add_rule` instead of `set_rule`, which was adding the condition of `and True` which had no effect. This patch corrects these moderate logic rules to use `set_rule` instead.
For the first time, I had a seed that started with Rock the Boat (allowed on moderate logic difficulty) and looking at the sphere tracker, I saw that |
Would the expert rule for The Twilight Bell Act Completion need to be changed to a set rule or an add_rule with "or" as well? |
Technically that rule is correct because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM and match my understanding of the game. Looked through the code for other similar cases and the only one I found was addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is changing some rules from adding True
to becoming True
. Adding True
like this can never be correct, so setting it to True
is the only thing that makes sense here.
Note: Adding True
with add_rule set to "or" is technically functional, but it's also sloppy compared to just setting it to True
What is this fixing or adding?
The moderate logic for the Mafia Town Clock Tower Chest and Top of Ruined Tower with nothing, and for clearing Rock the Boat without Ice Hat were mistakenly using
add_rule
instead ofset_rule
, which was adding the condition ofand True
which had no effect.This patch corrects these moderate logic rules to use
set_rule
instead.How was this tested?
A YAML was used with moderate logic difficulty and that act-plandos Rock the Boat onto the starting act and Barrel Battle onto the second act. The playthrough spheres in the spoiler were compared before and after. From additional generations with this YAML after the patch, both
Mafia Town - Top of Ruined Tower
andMafia Town - Clock Tower Chest
have been observed in sphere 1 of a playthrough as expected.