Core: Region handling customization #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
|
Not reviewing the code rn, but I'm super in favor of this exact way of doing this, over anything else that has been tried or suggested |
Ixrec
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Also strong agree with the concept. On its own this doesn't quite solve the "gotcha" for new world devs, but this is definitely a big part of the solution.
Code LGTM. It took me a while to wrap my head around how the BFS loops work, but that code is mostly pre-existing, and I'm not used to performance-sensitive Python anyway, so I dunno if it's worth aiming for higher readability there.
Merged
alwaysintreble
added
the
is: enhancement
NewSoupVi
approved these changes
Sep 5, 2024
NewSoupVi
added a commit
that referenced
this pull request
Sep 5, 2024
NewSoupVi
added a commit
that referenced
this pull request
Sep 5, 2024
NewSoupVi
added a commit
that referenced
this pull request
Nov 29, 2024
…name (#3887) * Docs: Mention explicit_indirect_conditions #3682 * Update world api.md * Docs: "Menu" -> origin_region_name #3682 * Update docs/world api.md Co-authored-by: Nicholas Saylor <[email protected]> * Update world api.md * I just didn't do this one and then Medic approved it anyway LMAO * Update world api.md --------- Co-authored-by: Nicholas Saylor <[email protected]>
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
…name (ArchipelagoMW#3887) * Docs: Mention explicit_indirect_conditions ArchipelagoMW#3682 * Update world api.md * Docs: "Menu" -> origin_region_name ArchipelagoMW#3682 * Update docs/world api.md Co-authored-by: Nicholas Saylor <[email protected]> * Update world api.md * I just didn't do this one and then Medic approved it anyway LMAO * Update world api.md --------- Co-authored-by: Nicholas Saylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds #1764 as a per-world-instance option, given we didn't find a more performant option and some devs would like to use it, it is now available as opt-in
It also adds World.origin_region_name, for worlds that don't want to start in "Menu"
The two changes are somewhat related and would conflict seperately, so for now I lumped them together.
How was this tested?
The original _update_reachable_regions_auto_indirect_conditions is a copy-paste with formatting changes, so that was tested in the PR 1764, the start name change I tested for this PR. It's a critical core functionality though, so additional testing is certainly welcome.