Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LADX: Probably fix generation error that palex had #3577

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

mrkssr
Copy link
Contributor

@mrkssr mrkssr commented Jun 22, 2024

What is this fixing or adding?

It's a duplicate of #2776 taking over from @zig-for with permission. It also includes the requested change by @Berserker66.

Change description from the original PR:

This needs further testing. The theory is that putting a STONE_BEAK on a dropped key causes this - but I don't remember how or why a regular STONE_BEAK can get put here instead of a STONE_BEAK3, etc.

Edit: this is almost certainly a foreign player's item that got put as a STONE_BEAK item icon."

How was this tested?

Generated multiple times with the player yamls from this Discord post.
Also changed the shuffle_stone_beaks option so there is an item from another player. Checked spoiler log. Generating worked everytime, also with foreign player item on a stone beak chest location.

If this makes graphical changes, please attach screenshots.

n/a

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 22, 2024
@Exempt-Medic Exempt-Medic added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jun 22, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches the change of the previous PR. I had a generation that failed before these changes and worked after them

Copy link
Contributor

@eudaimonistic eudaimonistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as I tested this exact change in the previous PR. This commit completely fixes the previous generation crash in all attempts I made, upwards of 50 super massive async generations north of 2000 and even 3000 varied worlds.

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 22, 2024
@NewSoupVi NewSoupVi merged commit 60a2692 into ArchipelagoMW:main Jun 22, 2024
17 checks passed
@mrkssr mrkssr deleted the LADX-Invalid-Literal branch June 22, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants