Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muse Dash: Song name change #3572

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

DeamonHunter
Copy link
Collaborator

@DeamonHunter DeamonHunter commented Jun 20, 2024

What is this fixing or adding?

Due to some circumstances, Territory Battles is being removed from CHUNITHM and Muse Dash followed suit. Its being replaced with Tsukuyomi Ni Naru as of the next update. This update is to get ahead and avoid a patch referencing a removed song.

Note: As the song is currently not released, the UID, song difficulties and whether it can be streamed is currently not known. Leaving the current song difficulties in as they should be "close enough" for now.

How was this tested?

With tests. Also should cause no issues as this song was not part of a main Archipelago version yet.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 20, 2024
@DeamonHunter DeamonHunter added the is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. label Jun 20, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Streamer Mode change makes sense, I'm a tiny bit worried the new song might be harder and so expected when it shouldn't be, but people can always just exclude the song in particular and it'll be quite unlikely to cause any significant problems

@NewSoupVi NewSoupVi merged commit 4f514e5 into ArchipelagoMW:main Jun 20, 2024
11 checks passed
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
* Change the song name of the removed song to the one replacing it.

* Make it not part of Streamable songs for now.
GameWyrm pushed a commit to GameWyrm/Archipelago-GW that referenced this pull request Jul 4, 2024
* Change the song name of the removed song to the one replacing it.

* Make it not part of Streamable songs for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants