id Tech 1 games: Reintroduce missing items #3561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for doom 2, some of the armor and health weights were nudged down to compensate for the addition of the megasphere for heretic, the torch was just added without changing anything else, as I felt doing so would negatively impact the distribution of artifacts (and personally I already feel there's too few in a game)
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
waiting-on: world-maintainer
ScipioWright
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Simple change, rates for Doom 2 have been adjusted in what looks like a reasonable manner (the values still add up to 198, which is a weird number, but whatever). Item ratios for Heretic were not adjusted the same way, but also it's not really that important to make them all scale perfectly.
|
Approved! Thanks a lot for the fix! |
ScipioWright
added
waiting-on: core-review
NewSoupVi
approved these changes
Jun 19, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
…rchipelagoMW#3561) for doom 2, some of the armor and health weights were nudged down to compensate for the addition of the megasphere for heretic, the torch was just added without changing anything else, as I felt doing so would negatively impact the distribution of artifacts (and personally I already feel there's too few in a game)
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…rchipelagoMW#3561) for doom 2, some of the armor and health weights were nudged down to compensate for the addition of the megasphere for heretic, the torch was just added without changing anything else, as I felt doing so would negatively impact the distribution of artifacts (and personally I already feel there's too few in a game)
GameWyrm
pushed a commit
to GameWyrm/Archipelago-GW
that referenced
this pull request
Jul 4, 2024
…rchipelagoMW#3561) for doom 2, some of the armor and health weights were nudged down to compensate for the addition of the megasphere for heretic, the torch was just added without changing anything else, as I felt doing so would negatively impact the distribution of artifacts (and personally I already feel there's too few in a game)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
In Doom II, the Megasphere (which was an item not in Doom 1993) is never added to the pool at all, despite already being present in AP's item list. In Heretic, the Torch is in a similar situation, not being added to the pool at all despite existing as a possible item.
Neither of these omissions seem to be intentional, and in fact I recall Daivuk stating in the past that the Megasphere in Doom II was completely forgotten about since so much of that is just copied from Doom 1993. So this PR aims to reintroduce these two items for a bit more added variety in multiworlds.
Also because I swear if I have to go through some of Heretic's darker rooms again without a torch--
How was this tested?
Generating a multiworld with these changes, and making sure both items appeared and function correctly.
If this makes graphical changes, please attach screenshots.
Receiving a Torch in game -- functionally identical to using !getitem Torch previously because everything was entirely functional beforehand, it's just now possible to do